Skip to content

Conversation

@lizlooney
Copy link
Collaborator

Store component information for each parameter in mrc_mechanism blocks.

Incremented version to 0.0.6. Added upgradeFrom_005_to_006.

This PR is in preparation for tackling issue #286, which I will do in a separate PR.

Incremented version to 0.0.6. Added upgradeFrom_005_to_006.

In mrc_mechanism.ts:
Store component information for each parameter.
@lizlooney lizlooney requested a review from alan412 November 21, 2025 04:44
Removed parametersHaveComponentInformation and mrcParametersHaveComponentInformation from mrc_mechanism.ts. These were set, but never actually used.
Removed upgrade_005_to_006 from mrc_mechanism.ts.
Copy link
Collaborator

@alan412 alan412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan412 alan412 merged commit a79cbfb into wpilibsuite:main Nov 22, 2025
1 check passed
@lizlooney lizlooney deleted the pr_mechanism_save_parameters_component_info branch November 22, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants