Skip to content

Conversation

@lizlooney
Copy link
Collaborator

Change the name of a component in the toolbox when the name field in a Component block is changed.

Fixes #289

…ditor.

Added editor parameter to mrcOnDescendantDisconnect and mrcOnMove methods in several blocks.
Added editor parameter to mrcDescendantsMayHaveChanged in mrc_mechanism_component_holder.
Removed handleToolboxUpdateRequest from App.tsx.
…boxAfterDelay to update the component name in the toolbox.
@lizlooney lizlooney requested a review from alan412 November 22, 2025 21:57
Copy link
Collaborator

@alan412 alan412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I found a couple bugs in testing but they aren't related to this PR so I am filing them as issues.

@alan412 alan412 merged commit 337f176 into wpilibsuite:main Nov 23, 2025
1 check passed
@lizlooney lizlooney deleted the pr_issue_289 branch November 24, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing the name of a component in a robot doesn't change in toolbox until saved...

2 participants