Fix bug with deleting the current project #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject has finished.
Collaborator
Author
|
I created this as a draft PR because I'm not sure that we should select another project and exit the dialog when the user deletes a project. What if they delete a project that isn't even the current project? What if they want to delete several project? |
…face into pr_issue_316
…rent project is the one being deleted. Also keep the dialog up after deleting a project. Renamed project to currentProject and setProject to setCurrentProject in MenuProps. Renamed project to currentProject and setProject to setCurrentProject in ProjectManageModalProps. Added "Project Management" to i18n.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified handleDeleteProject to select the next project after deleteProject has finished.
Fixes #316