Changed blocks to not assume they are BlockSvg #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ume they are BlockSvg.
alan412
reviewed
Nov 24, 2025
Collaborator
alan412
left a comment
alan412
left a comment
There was a problem hiding this comment.
Should we consider putting the code for if it is rendered and casting in the container that gets the mutatorIcon instead of in each block?
…face into pr_issue_297
Collaborator
Author
That's an interesting suggestion, but I think it is fine how we have it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed blocks (except the ones that are used in mutators) to not assume they are BlockSvg.
Fixes #297