-
Notifications
You must be signed in to change notification settings - Fork 8
Mechanisms #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Mechanisms #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, rename/copy mechanism, etc). Set the title of the workspace name modal bases on what is being done (new workspace, rename workspace, copy workspace). Set the title of the module name modal bases on what is being done (new workspace, rename workspace, copy workspace). Fixed a problem where the module type wasn't being passed to the python generator when it generates the python code for the UI. When a new module is selected and we are updating the blocks editor area, close the toolbox flyout if it is open. When saving a module to storage, include the module type. Improved the code that writes and reads modules (Workspaces, Mechanisms, and OpModes) to/from storage.
lizlooney
requested changes
Feb 14, 2025
Responding to PR comments, but it has to be let here.
Added mechanism modules to the app
lizlooney
reviewed
Feb 15, 2025
5. Workspace can have blocks | ||
6. No Robot workspace yet | ||
7. No Mechanism workspace yet | ||
8. Something weird is going on with currentModule getting unset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I fixed this in PR #45 !
lizlooney
approved these changes
Feb 15, 2025
…erface into mechanisms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of adding mechanisms. The toolbox is temporary for testing. Eventually this will be generated.
I put a list of what isn't working in readme.md