Skip to content

Conversation

lizlooney
Copy link
Collaborator

Fixes #53

@lizlooney lizlooney requested a review from alan412 February 22, 2025 23:35
Copy link
Collaborator

@alan412 alan412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like such a major change that there should be some tests for it. I'll try to run it through some manual testing tonight, but I wonder if we could create any automated tests for it.

@alan412
Copy link
Collaborator

alan412 commented Feb 26, 2025

did some rough manual testing. LGTM

@alan412 alan412 merged commit 479f398 into wpilibsuite:main Feb 26, 2025
1 check passed
@lizlooney lizlooney deleted the pr_async_storage branch February 26, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use async for storage functions instead of callbacks
2 participants