-
Notifications
You must be signed in to change notification settings - Fork 8
Add sample component for SparkFun LED Stick #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample component for SparkFun LED Stick #99
Conversation
Fixed toolbox for Rev Touch Sensor (from Alan).
…face into pr_sample_component_led_stick
…face into pr_sample_component_led_stick
…nction block. Handle case where a component name collides with a variable name. Added getComponentNames method to the editor class so the mrc_call_python_function blocks can populate the component name dropdown fields. Added robot parameter to OpMode init method. Modified mrc_class_method_def so it generates the call to super().__init__() for __init__ methods. Save the component names and types in the files. Added blocks to component_samples_category.ts.
This is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you create variables for each component used? It seems like we should just be self.robot.frontTouch.is_pressed()
so it is clear it is part of the robot instead of self.frontTouch.is_pressed()
Thanks for your review comments. PTAL. |
Change code generation to use self.robot.. |
…me> instead of self.<component name> Don't generate self.<component name> = robot.<component name> in the __init__ methods.
Show manufacturer name on toolbox categories.
OK. Now this is ready for another review. |
…face into pr_sample_component_led_stick
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.