add missing text domains #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akkspros
requested review from
derekherman and
jeffpaul
and removed request for
derekherman
Member
|
These changes look accurate to me. One thing I'm curious about that's mostly unrelated here is whether https://github.com/wptide/wp-tide-api/blob/develop/class-wp-tide-api.php should be renamed to wp-tide-api.php as the core plugin file so that it matches the repo/folder name (which is generally a standard for WP plugins)? |
Contributor
|
@jeffpaul in most cases the more WordPress way would be to have a file named same as the slug which will load this file. This file will fail PHPCS sniff because it has a class. So best option is to create a new “plugin” file that contains the plugin header and modified of last two lines that initiates it. |
Member
|
@akkspros any chance you're able to tackle the changes as noted via @rheinardkorf? |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing text domains