Merged
Conversation
tsubik
force-pushed
the
chore/rails-upgrade
branch
from
96fc45c to
20bdb13
Compare
santostiago
approved these changes
Feb 21, 2025
Contributor
santostiago
left a comment
santostiago
left a comment
There was a problem hiding this comment.
I approved this without testing. Do you want me to test it?
Collaborator
Author
|
@santostiago the code is on staging for a couple of weeks and there were no Sentry errors reported from that time and everything seems to work just fine. |
Collaborator
Author
|
I see one spec is failing after recent dependencies upgrade. I will take a look at that and merge when that is fixed. |
tsubik
force-pushed
the
chore/rails-upgrade
branch
from
20bdb13 to
1af54bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PT: https://www.pivotaltracker.com/story/show/188819174