Conversation
… copy-paste actions
Collaborator
Author
|
After small refactoring to not use ActiveAdmin jquery UI but native HTML dialog element. Additionaly, I updated styles to match the rest of the application. |
santostiago
reviewed
Mar 30, 2025
Contributor
santostiago
left a comment
santostiago
left a comment
There was a problem hiding this comment.
The code is good. Let me just test it.
santostiago
approved these changes
Mar 30, 2025
Contributor
santostiago
left a comment
santostiago
left a comment
There was a problem hiding this comment.
It looks fine.
But I see the x closing button on the left side and it doesn't work.
Am I missing some JS library?
Contributor
|
Collaborator
Author
|
Hmm, that looks weird on your end, like stylesheets are not refreshed somehow. Did you try to run |
Collaborator
Author
|
I pushed this to staging and also looks good to me, so I'm going to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PT: https://www.pivotaltracker.com/story/show/188819294