Fixing document API to not return attachment for invalid docs or not required#529
Merged
Fixing document API to not return attachment for invalid docs or not required#529
Conversation
santostiago
approved these changes
May 16, 2025
tsubik
force-pushed
the
fix/operator-document-api
branch
from
1321641 to
bd6453e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document API was returning attachments for invalid documents or not required (not sure if that should not be a validation rule to not have attachment if document was not required)
JIRA: https://gfw.atlassian.net/browse/OPEN-282?atlOrigin=eyJpIjoiMTc5NzJjYjYwYjZiNDVkMjhhYjg2ZTQxNjRhNjM4NzkiLCJwIjoiaiJ9