feat: [DS-259-update_footer_logos] Enable prop to add extra logos in the footer #116
Merged
richardblondet merged 3 commits intomainfrom Feb 2, 2026
Merged
feat: [DS-259-update_footer_logos] Enable prop to add extra logos in the footer #116richardblondet merged 3 commits intomainfrom
richardblondet merged 3 commits intomainfrom
Conversation
Changes to be committed: modified: src/components/Navigation/Footer/index.tsx modified: src/components/Navigation/Footer/styled.ts modified: src/components/Navigation/Footer/types.ts
Changes to be committed: modified: src/components/Navigation/Footer/FooterDemo.tsx modified: src/components/Navigation/Footer/index.tsx modified: src/components/Navigation/Footer/types.ts
|
❌ Versioning label check failed. Please apply exactly one of: Reason: missing |
1 similar comment
|
❌ Versioning label check failed. Please apply exactly one of: Reason: missing |
Changes to be committed: modified: src/components/Navigation/Footer/Footer.stories.tsx modified: src/components/Navigation/Footer/FooterDemo.tsx modified: src/components/Navigation/Footer/README.md
AlejoYarce
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #259
The Footer component currently renders only the WRI logo. This limits usage for collaborative projects, partnerships, and internal initiatives that need to display multiple organizational logos together for co-branding purposes.
What is the new behavior?
additionalLogosprop to Footer component accepting an array of React nodesfooterLogosContainerStylesproviding flex layout with proper alignment and gapWithAdditionalLogosstory to Footer.stories.tsx demonstrating the new propThis enhancement enables co-branding capabilities for internal projects and partnerships while preserving all existing footer functionality and responsive behavior.
Does this introduce a breaking change?
The
additionalLogosprop is optional and fully backward compatible. Existing implementations will continue working without any modifications.Other information
Files Modified:
src/components/Navigation/Footer/types.ts- AddedadditionalLogos?: React.ReactNode[]to FooterProps interfacesrc/components/Navigation/Footer/index.tsx- Implemented logo rendering logicsrc/components/Navigation/Footer/styled.ts- AddedfooterLogosContainerStylesfor layoutsrc/components/Navigation/Footer/FooterDemo.tsx- Added demo with sample partner logossrc/components/Navigation/Footer/Footer.stories.tsx- AddedWithAdditionalLogosstorysrc/components/Navigation/Footer/README.md- Updated documentation with new prop and exampleVisual Testing:
npm startto see the Footer with additional logos in the development environmentNavigation/Footer/WithAdditionalLogosUsage Example:
Notes: