Skip to content

DS-263 - update modal sizes#120

Merged
pesinasiller merged 1 commit intomainfrom
DS-263-update_modal_sizes
Feb 13, 2026
Merged

DS-263 - update modal sizes#120
pesinasiller merged 1 commit intomainfrom
DS-263-update_modal_sizes

Conversation

@pesinasiller
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

We change the variants to:

Extra small - width 240px; height hug; max-height 560px;

Small - width 320px; height hug; max-height 720px;

Medium - width 480px; height hug; max-height 720px;

Large - width 640px; height hug; max-height 720px;

Extra large - width 960px; height hug; max-height 720px;

Full-width - width 90%; height 90%; max-height unset;

All three parameters changed to be customisable values, so a prop for width, height, and max-height.
Screenshot 2026-02-12 at 7 42 54 p m

Does this introduce a breaking change?

  • Yes
  • No

Other information

@AlejoYarce AlejoYarce added minor and removed patch labels Feb 12, 2026
@pesinasiller pesinasiller merged commit de7a230 into main Feb 13, 2026
5 checks passed
@pesinasiller pesinasiller deleted the DS-263-update_modal_sizes branch February 13, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants