Skip to content

Comments

feat: [DS-268-InlineMessage_RDT_variation] enable left/right icon for InlineMessage Component#121

Draft
richardblondet wants to merge 2 commits intomainfrom
DS-268-InlineMessage_RDT_variation
Draft

feat: [DS-268-InlineMessage_RDT_variation] enable left/right icon for InlineMessage Component#121
richardblondet wants to merge 2 commits intomainfrom
DS-268-InlineMessage_RDT_variation

Conversation

@richardblondet
Copy link
Collaborator

Summary

Screenshot 2026-02-20 at 10 51 20

Changes to be committed:
modified: src/components/Status/InlineMessage/index.tsx
modified: src/components/Status/InlineMessage/styled.ts
modified: src/components/Status/InlineMessage/types.ts

Untracked files:
package-lock.json

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

…ineMessage Component

Changes to be committed:
	modified:   src/components/Status/InlineMessage/index.tsx
	modified:   src/components/Status/InlineMessage/styled.ts
	modified:   src/components/Status/InlineMessage/types.ts

Untracked files:
	package-lock.json
Changes to be committed:
	modified:   src/components/Status/InlineMessage/InlineMessage.stories.tsx
	modified:   src/components/Status/InlineMessage/InlineMessageDemo.tsx
@github-actions
Copy link

github-actions bot commented Feb 20, 2026

❌ Versioning label check failed.

Please apply exactly one of: major, minor, patch, no-bump.
See the labeling guide: https://github.com/wri/wri-design-systems/blob/main/README.md#pr-label-rules

Reason: missing
Current count (of allowed labels): 0

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the ability to specify left and right icons for the action button in the InlineMessage component. The feature enables more flexible button styling, particularly useful for cases where the InlineMessage doesn't have its own icon but the button needs one (e.g., a "Mark complete" button with a checkmark icon).

Changes:

  • Added buttonLeftIcon and buttonRightIcon optional props to InlineMessageProps
  • Improved caption rendering by making it conditional when caption is not provided
  • Adjusted caption styling to remove left margin when the InlineMessage has no icon
  • Added story and demo examples showcasing the new functionality

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/components/Status/InlineMessage/types.ts Added buttonLeftIcon and buttonRightIcon optional props to the type definition
src/components/Status/InlineMessage/styled.ts Enhanced inlineMessageCaptionStyles to conditionally apply left margin based on icon presence
src/components/Status/InlineMessage/index.tsx Forwarded new icon props to Button component and added conditional rendering for caption
src/components/Status/InlineMessage/InlineMessageDemo.tsx Added demo example showing InlineMessage without icon but with button left icon
src/components/Status/InlineMessage/InlineMessage.stories.tsx Added NoIconWithButtonIcon story demonstrating the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant