fix: add error toast for required fields in shared blueprint deployme…

[as-flow]

…nt - AB-849

Summary by CodeRabbit

• Bug Fixes
  • Added error notification to inform users when form validation fails, displaying a message about required fields.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A user-facing error toast notification is added to the shared blueprint deployment form, displaying "Please fill in all required fields" when validation fails before the deploy action returns.

Changes

Cohort / File(s)	Summary
Validation Error Toast src/ui/src/builder/settings/BuilderSettingsDeploySharedBlueprint.vue	Adds error toast feedback when form validation fails in handleDeploy, improving user experience by providing explicit error messaging before return.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• fix(ui): fix UI toast with actions - AB-305 #1125: Modifies the WdsToast component layout to support action buttons and close functionality, which directly relates to the toast notification implementation used in this PR's validation error handling.

Suggested reviewers

• madeindjs
• UladzislauK-Writer

Poem

🐰 A toast pops up with gentle care,
"Fill your fields!" it calls with flair,
No silent fails shall slip on through,
Users now know just what to do! 🍞✨

Pre-merge checks

❌ Failed checks (3 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	Title describes adding error toast for required fields, but linked issue AB-849 is about missing confirmation modal when deleting shared blueprints—different features.	Align PR title and changes with the linked issue AB-849, or link to an issue about validation error messages for deployment.
Linked Issues check	⚠️ Warning	PR adds validation error toast for deployment form, but linked issue AB-849 requires implementing a confirmation modal for deletion—unrelated features.	Implement the confirmation modal deletion feature from AB-849, or link to the appropriate issue tracking validation error messages.
Out of Scope Changes check	⚠️ Warning	Changes add form validation error handling for deployment, which is out of scope for the linked issue AB-849 about deletion confirmation modals.	Either implement the confirmation modal for deletion as specified in AB-849, or update linked issues to reflect validation error handling work.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7a9e941 and ec22f3e.

📒 Files selected for processing (1)

• src/ui/src/builder/settings/BuilderSettingsDeploySharedBlueprint.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: build (3.10)
• GitHub Check: tests (chromium)
• GitHub Check: tests (firefox)
• GitHub Check: tests (webkit)
• GitHub Check: build (3.12)
• GitHub Check: build (3.9)
• GitHub Check: build (3.11)
• GitHub Check: build (3.13)

🔇 Additional comments (2)

src/ui/src/builder/settings/BuilderSettingsDeploySharedBlueprint.vue (2)

1-351: Verify the PR's linked issue.

The linked issue AB-849 mentions "[Shared Blueprints] No confirmation modal when deleting from settings", but the actual implementation adds an error toast for required fields during deployment. Please confirm whether the correct issue is linked to this PR.

---

131-134: LGTM! Improves user feedback.

The toast notification provides clear feedback when required fields are missing, complementing the inline field errors. The implementation follows the existing toast pattern used throughout the component.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pullrequest]

HackerOne Code Security Review

🟢 Scan Complete: 1 Issue(s)
🟢 Validation Complete: The engineer who manually reviewed the code found one or more things that may need attention.
🟠 Issue(s) Resolved: 0 / 1

*We want to surface issues only when necessary and actionable. If we didn't get something right, or if there's more context we should take into account, reply to the comment so we'll know for the future.

Here's how the code changes were interpreted and info about the tools used for scanning.

📖 Summary of Changes

The changes involve adding a toast error message in the handleDeploy function of the BuilderSettingsDeploySharedBlueprint Vue component. This modification enhances user experience by providing immediate feedback when form validation fails during a deployment attempt, helping users understand why their submission was not processed.

File	Summary
src/ui/src/builder/settings/BuilderSettingsDeploySharedBlueprint.vue	A toast error message was added to the handleDeploy function when form validation fails, providing additional user feedback for incomplete form submissions.

ℹ️ Issues Detected

NOTE: These may not require action!

Below are unvalidated results from the Analysis Tools that ran during the latest scan for transparency. We investigate each of these for accuracy and relevance before surfacing them as a potential problem.

How will I know if something is a problem?
When validation completes, any concerns that warrant attention prior to merge will be posted as inline comments. These will show up in 2 ways:

• Expert review (most cases): Issues will be posted by experts who manually reviewed and validated them. These are real HackerOne engineers (not bots) reviewing through an integrated IDE-like tool. You can communicate with them like any other reviewer. They'll stay assigned and get notified with commit & comment updates.
• Automatically: In cases where our validation checks have highest confidence the problem is legitimate and urgent. These will include a description of contextual reasoning why & actionable next steps.

File & Line	Issue
src/ui/src/builder/settings/BuilderSettingsDeploySharedBlueprint.vue Line 131	The added code displays an error toast when form validation fails, but it doesn't sanitize the error message. While this particular implementation doesn't directly use user input in the error message, it establishes a pattern that could lead to XSS if similar code elsewhere includes user-provided data in toast messages.

🧰 Analysis tools

• [ ✅ ] HackerOne AI Code Analysis
• [ ✅ ] HackerOne AI Code Validation
• [ ✅ ] semgrep
• [ ✅ ] bandit

⏱️ Latest scan covered changes up to commit ec22f3e (latest)

[pullrequest]

Graham C has submitted feedback.

Graham C

---

Reviewed with ❤️ by PullRequest

[pullrequest]

It looks like the validation on the form is insufficient, not checking for maximum length of the values.

🔺 Vulnerability (Error)

Graham C