Add agent as subject type for agentic OBO tokens#2988
Open
Thumimku wants to merge 4 commits intowso2-extensions:masterfrom
Open
Add agent as subject type for agentic OBO tokens#2988Thumimku wants to merge 4 commits intowso2-extensions:masterfrom
Thumimku wants to merge 4 commits intowso2-extensions:masterfrom
Conversation
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
...ava/org/wso2/carbon/identity/oauth2/token/handlers/claims/AgentAccessTokenClaimProvider.java
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/oauth2/token/handlers/claims/AgentAccessTokenClaimProvider.java
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | Y | |
| #### Log Improvement Suggestion No: 2 | Y |
Thumimku
force-pushed
the
add_agent_type_for_OBO_token
branch
from
2de1b00 to
0fb87c5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2988 +/- ##
============================================
+ Coverage 56.08% 56.10% +0.01%
+ Complexity 10175 9889 -286
============================================
Files 676 676
Lines 58566 58573 +7
Branches 13842 13617 -225
============================================
+ Hits 32849 32864 +15
+ Misses 21101 21095 -6
+ Partials 4616 4614 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thumimku
force-pushed
the
add_agent_type_for_OBO_token
branch
from
05c2a9d to
8fb0714
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
This pull request updates the logic for agent-related claims in access tokens to support first class support for subject type identifier for agentic OBO tokens.
This can be supported for additional policies that can be enforced in API gateways or resource servers when they are dealing with agent.
This is following similar approach where the AUT claim for token issued directly to agent has "Agent" value.