Add versioning support for Pre-Issue Access Token action (v1)#3009
Add versioning support for Pre-Issue Access Token action (v1)#3009Lashen1227 wants to merge 14 commits intowso2-extensions:masterfrom
Conversation
…n-action-token-exchange
…nRequestBuilder classes
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
.../wso2/carbon/identity/oauth/action/execution/PreIssueAccessTokenActionVersioningHandler.java
Show resolved
Hide resolved
.../wso2/carbon/identity/oauth/action/execution/PreIssueAccessTokenActionVersioningHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/wso2/carbon/identity/oauth/action/versioning/ActionTriggerEvaluatorFactory.java
Show resolved
Hide resolved
...ain/java/org/wso2/carbon/identity/oauth/action/versioning/ActionTriggerEvaluatorFactory.java
Show resolved
Hide resolved
.../java/org/wso2/carbon/identity/oauth/action/versioning/ActionTriggerEvaluatorForVersion.java
Outdated
Show resolved
Hide resolved
.../java/org/wso2/carbon/identity/oauth/action/versioning/ActionTriggerEvaluatorForVersion.java
Outdated
Show resolved
Hide resolved
...g/wso2/carbon/identity/oauth/action/versioning/PreIssueAccessTokenRequestBuilderFactory.java
Show resolved
Hide resolved
...g/wso2/carbon/identity/oauth/action/versioning/PreIssueAccessTokenRequestBuilderFactory.java
Show resolved
Hide resolved
...org/wso2/carbon/identity/oauth/action/versioning/v1/PreIssueAccessTokenRequestBuilderV1.java
Show resolved
Hide resolved
...org/wso2/carbon/identity/oauth/action/versioning/v1/PreIssueAccessTokenRequestBuilderV1.java
Show resolved
Hide resolved
...ntity.oauth/src/main/java/org/wso2/carbon/identity/oauth/internal/OAuthServiceComponent.java
Show resolved
Hide resolved
...ntity.oauth/src/main/java/org/wso2/carbon/identity/oauth/internal/OAuthServiceComponent.java
Show resolved
Hide resolved
.../org/wso2/carbon/identity/oauth2/token/handlers/grant/AbstractAuthorizationGrantHandler.java
Show resolved
Hide resolved
.../org/wso2/carbon/identity/oauth2/token/handlers/grant/AbstractAuthorizationGrantHandler.java
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/oauth2/token/handlers/grant/ActionVersioningHandlerFactory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3009 +/- ##
============================================
- Coverage 58.77% 57.74% -1.03%
- Complexity 9933 10022 +89
============================================
Files 701 707 +6
Lines 54577 57376 +2799
Branches 12697 13052 +355
============================================
+ Hits 32078 33134 +1056
- Misses 18256 19841 +1585
- Partials 4243 4401 +158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
left a comment
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/20947509188
…e base test class
…date evaluation logic
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
This pull request introduces versioning support for the Pre-Issue Access Token action in the OAuth component. It adds new classes and factories to handle version-specific logic, integrates the versioning handler into the service component, and includes minor improvements and bug fixes related to grant handling and token audience assignment.
Versioning support for Pre-Issue Access Token action:
PreIssueAccessTokenActionConstantsto define version constants for the action.PreIssueAccessTokenActionVersioningHandlerto handle versioning logic for the Pre-Issue Access Token action, checking if the action can be executed based on the grant type.ActionTriggerEvaluatorFactoryandActionTriggerEvaluatorForVersionto provide version-specific trigger evaluation logic, currently supporting version "v1".PreIssueAccessTokenRequestBuilderFactoryto create request builders based on the action version.OAuthServiceComponentfor dependency injection and service discovery.