Skip to content

[Sync][master -> next][#3138]: skip cache remove for last login claim update#3150

Open
github-actions[bot] wants to merge 1 commit intonextfrom
sync-pr-3138-to-next
Open

[Sync][master -> next][#3138]: skip cache remove for last login claim update#3150
github-actions[bot] wants to merge 1 commit intonextfrom
sync-pr-3138-to-next

Conversation

@github-actions
Copy link
Copy Markdown

🤖 Auto-sync from master

This PR automatically syncs the changes from #3138 to the next branch.

Original PR: #3138
Author: @Thumimku
Total commits: 1
Workflow run: https://github.com/wso2-extensions/identity-inbound-auth-oauth/actions/runs/23631541487

Commits:

414765c8ac skip authz cache for last login

Comment on lines +335 to +348
*/
private void removeAuthzGrantCacheIfRequired(String userName, UserStoreManager userStoreManager)
throws UserStoreException {

if (isLastLoginTimeClaimUpdate() && !revokeCacheAtLoginEnabled()) {
if (log.isDebugEnabled()) {
log.debug("Skipping authz grant cache removal since the claim update is triggered by " +
"last login time update for user: " +
(LoggerUtils.isLogMaskingEnable ? LoggerUtils.getMaskedContent(userName) : userName) +
" and tenant: " + userStoreManager.getTenantId());
}
} else {
OAuthUtil.removeAuthzGrantCacheForUser(userName, userStoreManager);
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log Improvement Suggestion No: 1

Suggested change
*/
private void removeAuthzGrantCacheIfRequired(String userName, UserStoreManager userStoreManager)
throws UserStoreException {
if (isLastLoginTimeClaimUpdate() && !revokeCacheAtLoginEnabled()) {
if (log.isDebugEnabled()) {
log.debug("Skipping authz grant cache removal since the claim update is triggered by " +
"last login time update for user: " +
(LoggerUtils.isLogMaskingEnable ? LoggerUtils.getMaskedContent(userName) : userName) +
" and tenant: " + userStoreManager.getTenantId());
}
} else {
OAuthUtil.removeAuthzGrantCacheForUser(userName, userStoreManager);
}
private void removeAuthzGrantCacheIfRequired(String userName, UserStoreManager userStoreManager)
throws UserStoreException {
if (isLastLoginTimeClaimUpdate() && !revokeCacheAtLoginEnabled()) {
if (log.isDebugEnabled()) {
log.debug("Skipping authz grant cache removal since the claim update is triggered by " +
"last login time update for user: " +
(LoggerUtils.isLogMaskingEnable ? LoggerUtils.getMaskedContent(userName) : userName) +
" and tenant: " + userStoreManager.getTenantId());
}
} else {
if (log.isDebugEnabled()) {
log.debug("Removing authz grant cache for user: " +
(LoggerUtils.isLogMaskingEnable ? LoggerUtils.getMaskedContent(userName) : userName) +
" and tenant: " + userStoreManager.getTenantId());
}
OAuthUtil.removeAuthzGrantCacheForUser(userName, userStoreManager);

Copy link
Copy Markdown
Contributor

@wso2-engineering wso2-engineering bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Agent Log Improvement Checklist

⚠️ Warning: AI-Generated Review Comments

  • The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
  • Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.

✅ Before merging this pull request:

  • Review all AI-generated comments for accuracy and relevance.
  • Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Comment Accepted (Y/N) Reason
#### Log Improvement Suggestion No: 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant