Improve token validation for sub organization applications#3153
Draft
ShanChathusanda93 wants to merge 1 commit intowso2-extensions:masterfrom
Draft
Improve token validation for sub organization applications#3153ShanChathusanda93 wants to merge 1 commit intowso2-extensions:masterfrom
ShanChathusanda93 wants to merge 1 commit intowso2-extensions:masterfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
123
to
+124
| introspectionRequest.setRequiredClaimURIs(claimsUris); | ||
| OAuth2TokenValidationRequestDTO.TokenValidationContextParam contextParam = |
Contributor
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| introspectionRequest.setRequiredClaimURIs(claimsUris); | |
| OAuth2TokenValidationRequestDTO.TokenValidationContextParam contextParam = | |
| introspectionRequest.setRequiredClaimURIs(claimsUris); | |
| log.debug("Setting introspection context parameter for token validation"); | |
| OAuth2TokenValidationRequestDTO.TokenValidationContextParam contextParam = |
Comment on lines
+129
to
130
| new OAuth2TokenValidationRequestDTO.TokenValidationContextParam[]{contextParam}); | ||
|
|
Contributor
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
Suggested change
| new OAuth2TokenValidationRequestDTO.TokenValidationContextParam[]{contextParam}); | |
| new OAuth2TokenValidationRequestDTO.TokenValidationContextParam[]{contextParam}); | |
| log.info("Initiating OAuth2 token introspection request"); |
Comment on lines
571
to
+573
| .getVerifiedAccessToken(validationRequest.getAccessToken().getIdentifier(), false); | ||
| OAuth2TokenValidationRequestDTO.TokenValidationContextParam[] validationContextParam = | ||
| validationRequest.getContext(); |
Contributor
There was a problem hiding this comment.
Log Improvement Suggestion No: 3
Suggested change
| .getVerifiedAccessToken(validationRequest.getAccessToken().getIdentifier(), false); | |
| OAuth2TokenValidationRequestDTO.TokenValidationContextParam[] validationContextParam = | |
| validationRequest.getContext(); | |
| OAuth2TokenValidationRequestDTO.TokenValidationContextParam[] validationContextParam = | |
| validationRequest.getContext(); | |
| log.debug("Starting token validation for introspection request"); |
Comment on lines
+1068
to
+1070
| int appResidentTenantId = accessTokenDO.getAppResidentTenantId(); | ||
| String accessingOrgIdFromPath = PrivilegedCarbonContext.getThreadLocalCarbonContext(). | ||
| getAccessingOrganizationId(); |
Contributor
There was a problem hiding this comment.
Log Improvement Suggestion No: 4
Suggested change
| int appResidentTenantId = accessTokenDO.getAppResidentTenantId(); | |
| String accessingOrgIdFromPath = PrivilegedCarbonContext.getThreadLocalCarbonContext(). | |
| getAccessingOrganizationId(); | |
| int appResidentTenantId = accessTokenDO.getAppResidentTenantId(); | |
| String accessingOrgIdFromPath = PrivilegedCarbonContext.getThreadLocalCarbonContext(). | |
| getAccessingOrganizationId(); | |
| log.debug("Validating introspection for sub-organization tokens. App resident tenant ID: " + | |
| appResidentTenantId); |
Contributor
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | ||
| #### Log Improvement Suggestion No: 2 | ||
| #### Log Improvement Suggestion No: 3 | ||
| #### Log Improvement Suggestion No: 4 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3153 +/- ##
============================================
- Coverage 59.71% 57.07% -2.65%
- Complexity 10229 10880 +651
============================================
Files 709 709
Lines 55689 61666 +5977
Branches 13905 15123 +1218
============================================
+ Hits 33255 35196 +1941
- Misses 18055 21748 +3693
- Partials 4379 4722 +343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
[List all changes you want to add here. If you fixed an issue, please
add a reference to that issue as well.]
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Developer Checklist (Mandatory)
product-isissue to track any behavioral change or migration impact.Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation