Skip to content

Improve organization check to get allowed issuers#3154

Open
ShanChathusanda93 wants to merge 1 commit intowso2-extensions:masterfrom
ShanChathusanda93:issuer-usage-scope-impr-branch
Open

Improve organization check to get allowed issuers#3154
ShanChathusanda93 wants to merge 1 commit intowso2-extensions:masterfrom
ShanChathusanda93:issuer-usage-scope-impr-branch

Conversation

@ShanChathusanda93
Copy link
Copy Markdown
Contributor

Proposed changes in this pull request

Copy link
Copy Markdown
Contributor

@wso2-engineering wso2-engineering bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Agent Log Improvement Checklist

⚠️ Warning: AI-Generated Review Comments

  • The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
  • Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.

✅ Before merging this pull request:

  • Review all AI-generated comments for accuracy and relevance.
  • Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Comment Accepted (Y/N) Reason
#### Log Improvement Suggestion No: 1
#### Log Improvement Suggestion No: 2

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Warning

Rate limit exceeded

@ShanChathusanda93 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 23 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 21 minutes and 23 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 769ef830-4a02-460c-908d-2be6da465434

📥 Commits

Reviewing files that changed from the base of the PR and between b3b75fd and 6664395.

📒 Files selected for processing (2)
  • components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/config/services/OAuth2OIDCConfigOrgUsageScopeMgtServiceImpl.java
  • components/org.wso2.carbon.identity.oauth/src/test/java/org/wso2/carbon/identity/oauth2/config/services/OAuth2OIDCConfigOrgUsageScopeMgtServiceImplTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShanChathusanda93 ShanChathusanda93 force-pushed the issuer-usage-scope-impr-branch branch from 36a3dc7 to 30efb94 Compare March 30, 2026 11:38
@ShanChathusanda93 ShanChathusanda93 changed the title Improve organization check and error description for usage scope reject error Improve organization check and error description for usage scope update reject error Mar 30, 2026
@ShanChathusanda93 ShanChathusanda93 force-pushed the issuer-usage-scope-impr-branch branch from 30efb94 to ae52058 Compare March 30, 2026 11:40
@ShanChathusanda93 ShanChathusanda93 force-pushed the issuer-usage-scope-impr-branch branch from ae52058 to 6664395 Compare March 30, 2026 11:46
@ShanChathusanda93 ShanChathusanda93 changed the title Improve organization check and error description for usage scope update reject error Improve organization check to get allowed issuers Mar 30, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.74%. Comparing base (b3b75fd) to head (6664395).

Files with missing lines Patch % Lines
...s/OAuth2OIDCConfigOrgUsageScopeMgtServiceImpl.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3154      +/-   ##
============================================
- Coverage     59.75%   59.74%   -0.01%     
+ Complexity    10247    10233      -14     
============================================
  Files           709      709              
  Lines         55703    55703              
  Branches      13945    13945              
============================================
- Hits          33283    33282       -1     
  Misses        18042    18042              
- Partials       4378     4379       +1     
Flag Coverage Δ
unit 42.71% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant