Add org level config to govern TOTP enrolment in the user login #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
...src/main/java/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticator.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticator.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Show resolved
Hide resolved
...rbon/identity/application/authenticator/totp/internal/TOTPAuthenticatorServiceComponent.java
Show resolved
Hide resolved
...rbon/identity/application/authenticator/totp/internal/TOTPAuthenticatorServiceComponent.java
Show resolved
Hide resolved
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
11 tasks
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/org/wso2/carbon/identity/application/authenticator/totp/util/TOTPUtil.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/org/wso2/carbon/identity/application/authenticator/totp/util/TOTPUtil.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/org/wso2/carbon/identity/application/authenticator/totp/util/TOTPUtil.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/org/wso2/carbon/identity/application/authenticator/totp/util/TOTPUtil.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Jan 26, 2026
...rbon/identity/application/authenticator/totp/internal/TOTPAuthenticatorServiceComponent.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...tor/src/main/java/org/wso2/carbon/identity/application/authenticator/totp/util/TOTPUtil.java
Show resolved
Hide resolved
...tor/src/main/java/org/wso2/carbon/identity/application/authenticator/totp/util/TOTPUtil.java
Show resolved
Hide resolved
...rbon/identity/application/authenticator/totp/internal/TOTPAuthenticatorServiceComponent.java
Show resolved
Hide resolved
...test/java/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorTest.java
Show resolved
Hide resolved
...test/java/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorTest.java
Outdated
Show resolved
Hide resolved
...tor/src/main/java/org/wso2/carbon/identity/application/authenticator/totp/util/TOTPUtil.java
Show resolved
Hide resolved
...tor/src/main/java/org/wso2/carbon/identity/application/authenticator/totp/util/TOTPUtil.java
Show resolved
Hide resolved
AnuradhaSK
reviewed
Jan 26, 2026
AnuradhaSK
reviewed
Jan 26, 2026
AnuradhaSK
reviewed
Jan 26, 2026
...ava/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorConfigImpl.java
Outdated
Show resolved
Hide resolved
...test/java/org/wso2/carbon/identity/application/authenticator/totp/TOTPAuthenticatorTest.java
Outdated
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Jan 26, 2026
jenkins-is-staging
left a comment
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/21357156287
...src/test/java/org/wso2/carbon/identity/application/authenticator/totp/util/TOTPUtilTest.java
Outdated
Show resolved
Hide resolved
DilshanSenarath
approved these changes
Jan 27, 2026
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce an organization-level configuration in WSO2 Identity Server to control TOTP enrollment during user login. This adds a global setting that serves as the default behavior for all applications while still allowing application-level overrides through conditional authentication scripts.
Related Issues
Related PRs