Implement dynamic titles and updated icons (favicon/header) for the console #277
+219
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasika2012
changed the title
Contributor
📝 WalkthroughWalkthroughAdds a theme-aware Logo component, a useDocumentTitle hook, HTML metadata and favicon updates, replaces an inline logo with the external Logo in the navbar, and re-exports the new Logo and hooks via barrel files. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rasika2012
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@console/workspaces/libs/views/src/hooks/useDocumentTitle.ts`:
- Around line 19-48: The hook currently uses baseTitleRef to capture
document.title but nested uses can read an already-modified title and cleanup
resets incorrectly; update useDocumentTitle to capture and restore the previous
title per hook instance: add a prevTitleRef (e.g., prevTitleRef.current =
document.title) on mount before changing document.title, use a module-level
initialBaseTitle (or keep baseTitleRef as the single cached original) so
baseTitleRef only stores the very first original title (document.title ||
baseTitleFallback) and never the modified one, update document.title to
`${title} | ${baseTitleRef.current}` and in the cleanup restore
prevTitleRef.current (not baseTitleRef.current) so nested components revert to
their immediate previous title.
🧹 Nitpick comments (2)
console/workspaces/libs/views/src/component/MainLayout/subcomponents/NavBarToolbar.tsx (2)
105-122: Redundant outer Box wrapper withgap: 1.5.The outer
Box(lines 105-111) specifiesgap: 1.5but contains only a single child element (the innerBox). Thegapproperty has no effect with one child. Consider simplifying by removing the outer wrapper.♻️ Suggested simplification
- <Box - sx={{ - display: 'flex', - alignItems: 'center', - gap: 1.5, - }} - > - <Box - sx={{ - width: theme.spacing(24), - display: 'flex', - alignItems: 'center', - justifyContent: 'center', - }} - > - <Logo /> - </Box> - </Box> + <Box + sx={{ + width: theme.spacing(24), + display: 'flex', + alignItems: 'center', + justifyContent: 'center', + }} + > + <Logo /> + </Box>
34-35: Missing blank line between import and interface declaration.There should be a blank line separating the import statements from the interface declaration for better readability.
♻️ Suggested fix
import { Logo } from '../../Logo/Logo'; + export interface NavBarToolbarProps {
nadheesh
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several improvements to the web application's branding, user interface, and usability. The most significant changes include the addition of a new
Logocomponent with a scalable SVG logo, enhancements to the document title handling for improved accessibility and SEO, and updates to the main layout to reflect the new branding. Additionally, the HTML metadata has been expanded for better social sharing and discoverability.Branding and UI Enhancements:
Logocomponent as an SVG, which adapts to the color scheme and replaces the previous placeholder logo in the navigation bar. (console/workspaces/libs/views/src/component/Logo/Logo.tsx,console/workspaces/libs/views/src/component/Logo/index.ts,console/workspaces/libs/views/src/component/MainLayout/subcomponents/NavBarToolbar.tsx, [1] [2] [3] [4]console/apps/webapp/index.html, console/apps/webapp/index.htmlL5-R23)Usability Improvements:
useDocumentTitleReact hook to dynamically set the document title based on the current page, and integrated it into thePageLayoutcomponent for consistent title updates. (console/workspaces/libs/views/src/hooks/useDocumentTitle.ts,console/workspaces/libs/views/src/component/PageLayout/PageLayout.tsx, [1] [2] [3]Logocomponent anduseDocumentTitlehook from the sharedviewslibrary for use throughout the application. (console/workspaces/libs/views/src/component/index.ts,console/workspaces/libs/views/src/hooks/index.ts,console/workspaces/libs/views/src/index.ts, [1] [2] [3]Issue: #276
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning
Summary by CodeRabbit
New Features
UI/Style Updates