Skip to content

Fix app sharing groups not shown in subscription wizardFix bug#1288

Open
e19166 wants to merge 2 commits intowso2:mainfrom
e19166:main
Open

Fix app sharing groups not shown in subscription wizardFix bug#1288
e19166 wants to merge 2 commits intowso2:mainfrom
e19166:main

Conversation

@e19166
Copy link
Copy Markdown
Contributor

@e19166 e19166 commented Mar 27, 2026

Purpose

Fixes the Subscription & Key Generation Wizard not showing Application Groups during application creation even when application sharing is enabled.
Resolves issue: Application groups missing in Subscription & Key Generation Wizard when app sharing is enabled.

Goals

Ensure the wizard displays the Application Groups field when application sharing is enabled.
Keep behavior consistent with the standard application creation form in the Dev Portal.

Approach

Read applicationSharingEnabled from SettingsContext in CreateAppStep.jsx.
Pass it to ApplicationCreateForm via isApplicationSharingEnabled so the form renders the groups field.
Simplify the flag derivation using optional chaining (settingsContext?.settings?.applicationSharingEnabled) to keep it null-safe.

Summary by CodeRabbit

  • Style

    • Improved vertical spacing in the application credentials wizard button panel for enhanced visual presentation.
  • New Features

    • Application sharing functionality is now dynamically configurable during the application creation process, with system settings controlling feature availability.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a1d02118-e9d6-4cc2-a0c9-88e9b281c233

📥 Commits

Reviewing files that changed from the base of the PR and between 90a8ef5 and efab0c2.

📒 Files selected for processing (2)
  • portals/devportal/src/main/webapp/source/src/app/components/Apis/Details/Credentials/Wizard/ButtonPanel.jsx
  • portals/devportal/src/main/webapp/source/src/app/components/Apis/Details/Credentials/Wizard/CreateAppStep.jsx

Walkthrough

Two styling and configuration changes to the Credentials Wizard component: ButtonPanel receives additional vertical margin spacing, and CreateAppStep now consumes SettingsContext to retrieve application sharing configuration, passing it as a prop to ApplicationCreateForm.

Changes

Cohort / File(s) Summary
Wizard Component Styling
portals/devportal/.../Credentials/Wizard/ButtonPanel.jsx
Added mt: 2 margin-top spacing to the wizardButtons style object.
Wizard Context Integration
portals/devportal/.../Credentials/Wizard/CreateAppStep.jsx
Integrated SettingsContext hook to extract isApplicationSharingEnabled setting and pass it as a new prop to ApplicationCreateForm.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A wizard's buttons need some breathing room,
Settings now flow through the form with zoom,
Context whispers what sharing should be—
Small changes stack like carrots, you see! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions 'Fix app sharing groups not shown in subscription wizard' which directly aligns with the PR's stated purpose of fixing application groups missing in the wizard when app sharing is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants