Introduce new Terraform modules for Child DNS Zones and ACR scoped tokens#164
Merged
athiththan11 merged 12 commits intowso2:mainfrom Jun 5, 2025
Merged
Introduce new Terraform modules for Child DNS Zones and ACR scoped tokens#164athiththan11 merged 12 commits intowso2:mainfrom
athiththan11 merged 12 commits intowso2:mainfrom
Conversation
shananjana
approved these changes
Jun 5, 2025
SachithKasthuriarachchi
approved these changes
Jun 5, 2025
chalitha1989
approved these changes
Jun 5, 2025
athiththan11
requested changes
Jun 5, 2025
Member
athiththan11
left a comment
athiththan11
left a comment
There was a problem hiding this comment.
Please update the PR with proper title and a description and also go through the review comments
SazniMohamed
reviewed
Jun 5, 2025
SazniMohamed
reviewed
Jun 5, 2025
ranikamadurawe
changed the title
SazniMohamed
reviewed
Jun 5, 2025
SazniMohamed
reviewed
Jun 5, 2025
SazniMohamed
reviewed
Jun 5, 2025
SazniMohamed
reviewed
Jun 5, 2025
SazniMohamed
reviewed
Jun 5, 2025
SazniMohamed
requested changes
Jun 5, 2025
VimukthiPerera
requested changes
Jun 5, 2025
athiththan11
approved these changes
Jun 5, 2025
VimukthiPerera
approved these changes
Jun 5, 2025
SazniMohamed
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces two new Azure modules
New Module Child DNS Zone
This module creates a Child DNS Zone under a provided dns zone under the
base_dns_namevariable. This also create the necessary NS records to the Base NameserverNew ACR Token
This module creates a ACR Scope Map and token to get access to a specific set of ACR resources