Fix Oracle Registry DB Connection Fails Due to Validation Query Misconfiguration#4440
Merged
KD23243 merged 1 commit intowso2:4.10.xfrom Dec 10, 2025
Merged
Fix Oracle Registry DB Connection Fails Due to Validation Query Misconfiguration#4440KD23243 merged 1 commit intowso2:4.10.xfrom
KD23243 merged 1 commit intowso2:4.10.xfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
pavinduLakshan
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Purpose
This PR fixes the issue where Oracle-based external databases fail to validate connections when used as the local registry database in WSO2 Identity Server.
Previously, the validation query configuration in
<IS_HOME>/repository/resources/conf/default.jsonand<IS_HOME>/repository/resources/conf/infer.jsonused an incorrect keydatabase.$1.validationQueryinstead of the correctdatabase.$1.pool_options.validationQuery. As a result, the defaultSELECT 1query was applied for all databases, causing connection validation failures in Oracle (SELECT 1 is invalid in Oracle).Changes
Updated the JSON configuration to use
database.$1.pool_options.validationQueryfor all database types.Manual Testing
Screen.Recording.2025-11-20.at.9.08.19.AM.mov