Skip to content

Pass userStoreManager for store identity claim config retrieval#4450

Merged
PasinduYeshan merged 1 commit intowso2:4.10.xfrom
PasinduYeshan:fix/store-identity2
Jan 6, 2026
Merged

Pass userStoreManager for store identity claim config retrieval#4450
PasinduYeshan merged 1 commit intowso2:4.10.xfrom
PasinduYeshan:fix/store-identity2

Conversation

@PasinduYeshan
Copy link
Copy Markdown

@PasinduYeshan PasinduYeshan commented Jan 6, 2026

This pull request updates the way identity claims are mapped in user store filtering operations by passing the UserStoreManager instance to the mapAttributesToLocalIdentityClaims method. This change ensures that claim mapping logic can utilize the specific user store manager context, improving accuracy and flexibility in scenarios involving secondary user stores.

Enhancements to identity claim mapping:

  • The mapAttributesToLocalIdentityClaims method in AbstractUserStoreManager.java now accepts a UserStoreManager parameter, allowing it to operate with the correct user store context.
  • All invocations of mapAttributesToLocalIdentityClaims in methods like getUserListWithID, getPaginatedUserListWithID, and getUsersCount have been updated to pass the secondaryUserStoreManager argument. [1] [2] [3]
  • The call to isIdentityStoreManagedClaim within mapAttributesToLocalIdentityClaims now uses the provided userStoreManager instead of null, ensuring accurate claim management based on the current user store.

Related Issues

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@wso2-engineering wso2-engineering bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Agent Log Improvement Checklist

⚠️ Warning: AI-Generated Review Comments

  • The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
  • Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.

✅ Before merging this pull request:

  • Review all AI-generated comments for accuracy and relevance.
  • Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Comment Accepted (Y/N) Reason
#### Log Improvement Suggestion No: 1

@PasinduYeshan
Copy link
Copy Markdown
Author

image

@PasinduYeshan
Copy link
Copy Markdown
Author

@PasinduYeshan
Copy link
Copy Markdown
Author

image

@PasinduYeshan PasinduYeshan merged commit 7d9e482 into wso2:4.10.x Jan 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants