Add method to retrieve key store file location based on context#4458
Add method to retrieve key store file location based on context#4458ThaminduR merged 1 commit intowso2:4.10.xfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
core/org.wso2.carbon.utils/src/main/java/org/wso2/carbon/utils/security/KeystoreUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 |
There was a problem hiding this comment.
Pull request overview
This pull request adds an overloaded utility method to KeystoreUtils for generating context-specific keystore file locations. The new method allows keystore file names to incorporate both a context identifier and tenant domain, separated by --, enabling more flexible keystore management when context-specific keystores are needed.
Changes:
- Added
getKeyStoreFileLocation(String context, String tenantDomain)method that generates keystore file locations with the pattern:{tenantDomain}--{context}{extension}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/org.wso2.carbon.utils/src/main/java/org/wso2/carbon/utils/security/KeystoreUtils.java
Show resolved
Hide resolved
core/org.wso2.carbon.utils/src/main/java/org/wso2/carbon/utils/security/KeystoreUtils.java
Outdated
Show resolved
Hide resolved
core/org.wso2.carbon.utils/src/main/java/org/wso2/carbon/utils/security/KeystoreUtils.java
Outdated
Show resolved
Hide resolved
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/21425666428
Issue
wso2/product-is#26491
This pull request introduces an overloaded utility method to the
KeystoreUtilsclass, allowing retrieval of a keystore file location using both acontextand atenantDomain. This enhancement enables more flexible file naming, especially when a context-specific keystore is needed.Key change:
getKeyStoreFileLocation(String context, String tenantDomain)to generate a keystore file location string that incorporates both the context and tenant domain, separated by--, improving support for context-specific keystores.