Skip to content

Add method to retrieve key store file location based on context#4458

Merged
ThaminduR merged 1 commit intowso2:4.10.xfrom
ThaminduR:fix-26491
Jan 30, 2026
Merged

Add method to retrieve key store file location based on context#4458
ThaminduR merged 1 commit intowso2:4.10.xfrom
ThaminduR:fix-26491

Conversation

@ThaminduR
Copy link

Issue

wso2/product-is#26491

This pull request introduces an overloaded utility method to the KeystoreUtils class, allowing retrieval of a keystore file location using both a context and a tenantDomain. This enhancement enables more flexible file naming, especially when a context-specific keystore is needed.

Key change:

  • Added a new overloaded method getKeyStoreFileLocation(String context, String tenantDomain) to generate a keystore file location string that incorporates both the context and tenant domain, separated by --, improving support for context-specific keystores.

Copilot AI review requested due to automatic review settings January 21, 2026 08:26
@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@wso2-engineering wso2-engineering bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Agent Log Improvement Checklist

⚠️ Warning: AI-Generated Review Comments

  • The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
  • Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.

✅ Before merging this pull request:

  • Review all AI-generated comments for accuracy and relevance.
  • Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Comment Accepted (Y/N) Reason
#### Log Improvement Suggestion No: 1

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds an overloaded utility method to KeystoreUtils for generating context-specific keystore file locations. The new method allows keystore file names to incorporate both a context identifier and tenant domain, separated by --, enabling more flexible keystore management when context-specific keystores are needed.

Changes:

  • Added getKeyStoreFileLocation(String context, String tenantDomain) method that generates keystore file locations with the pattern: {tenantDomain}--{context}{extension}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/21425666428

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/21425666428
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/21425666428

@ThaminduR ThaminduR merged commit aa1da2a into wso2:4.10.x Jan 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants