Revert "Fix the startup error log with FileUploadExecutorManager"#4502
Closed
madurangasiriwardena wants to merge 1 commit into4.12.xfrom
Closed
Revert "Fix the startup error log with FileUploadExecutorManager"#4502madurangasiriwardena wants to merge 1 commit into4.12.xfrom
madurangasiriwardena wants to merge 1 commit into4.12.xfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
+254
to
+259
| Servlet fileUploadServlet; | ||
| if (isLocalTransportMode) { | ||
| fileUploadServlet = new FileUploadServlet(context, serverConfigContext, webContext); | ||
| } else { | ||
| fileUploadServlet = new FileUploadServlet(context, clientConfigContext, webContext); | ||
| } |
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| Servlet fileUploadServlet; | |
| if (isLocalTransportMode) { | |
| fileUploadServlet = new FileUploadServlet(context, serverConfigContext, webContext); | |
| } else { | |
| fileUploadServlet = new FileUploadServlet(context, clientConfigContext, webContext); | |
| } | |
| Servlet fileUploadServlet; | |
| if (isLocalTransportMode) { | |
| log.debug("Creating FileUploadServlet with server configuration context for local transport mode"); | |
| fileUploadServlet = new FileUploadServlet(context, serverConfigContext, webContext); | |
| } else { | |
| log.debug("Creating FileUploadServlet with client configuration context"); | |
| fileUploadServlet = new FileUploadServlet(context, clientConfigContext, webContext); | |
| } |
Comment on lines
260
to
262
| Dictionary<String, String> fileUploadServletProperties = new Hashtable<>(); | ||
| fileUploadServletProperties.put(HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN, | ||
| "/carbon/fileupload/*"); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
Suggested change
| Dictionary<String, String> fileUploadServletProperties = new Hashtable<>(); | |
| fileUploadServletProperties.put(HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN, | |
| "/carbon/fileupload/*"); | |
| Dictionary<String, String> fileUploadServletProperties = new Hashtable<>(); | |
| fileUploadServletProperties.put(HttpWhiteboardConstants.HTTP_WHITEBOARD_SERVLET_PATTERN, | |
| "/carbon/fileupload/*"); | |
| log.info("Registering FileUploadServlet with pattern: /carbon/fileupload/*"); |
Comment on lines
71
to
73
| public void init(ServletConfig servletConfig) throws ServletException { | ||
| this.servletConfig = servletConfig; | ||
| try { |
There was a problem hiding this comment.
Log Improvement Suggestion No: 3
Suggested change
| public void init(ServletConfig servletConfig) throws ServletException { | |
| this.servletConfig = servletConfig; | |
| try { | |
| this.servletConfig = servletConfig; | |
| try { | |
| log.info("Initializing FileUploadServlet for web context: " + webContext); |
Comment on lines
+75
to
+76
| //Registering FileUploadExecutor Manager as an OSGi service | ||
| bundleContext.registerService(FileUploadExecutorManager.class.getName(), fileUploadExecutorManager, null); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 4
Suggested change
| //Registering FileUploadExecutor Manager as an OSGi service | |
| bundleContext.registerService(FileUploadExecutorManager.class.getName(), fileUploadExecutorManager, null); | |
| //Registering FileUploadExecutor Manager as an OSGi service | |
| bundleContext.registerService(FileUploadExecutorManager.class.getName(), fileUploadExecutorManager, null); | |
| log.debug("FileUploadExecutorManager registered as OSGi service successfully"); |
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | ||
| #### Log Improvement Suggestion No: 2 | ||
| #### Log Improvement Suggestion No: 3 | ||
| #### Log Improvement Suggestion No: 4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4495