Limit the federated IDP authenticator property update based on the configured max limit#999
Merged
sadilchamishka merged 1 commit intowso2:masterfrom Sep 12, 2025
Conversation
…nfigured max limit
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation to limit the number of properties that can be configured for federated authenticators in identity providers, enforcing a configurable maximum limit.
Key changes:
- Added validation during IDP creation and federated authenticator updates to check property count limits
- Introduced a new error code for when the maximum property limit is exceeded
- Added a configurable constant for the maximum federated authenticator property limit
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ServerIdpManagementService.java | Adds validation methods and calls to enforce property limits during IDP creation and authenticator updates |
| Constants.java | Defines the configuration property name and error message for property limit validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...rc/main/java/org/wso2/carbon/identity/api/server/idp/v1/core/ServerIdpManagementService.java
Show resolved
Hide resolved
...rc/main/java/org/wso2/carbon/identity/api/server/idp/v1/core/ServerIdpManagementService.java
Show resolved
Hide resolved
janakamarasena
approved these changes
Sep 12, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose