-
Notifications
You must be signed in to change notification settings - Fork 335
Update the style guide (md) #9569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe STYLE-GUIDE.md document was completely restructured, replacing the previous WSO2 Identity Apps Style Guide with a comprehensive, modular guide covering styling architecture, component guidelines, UI system integration, theme customization, and migration strategy. The new guide establishes a two-library system (Oxygen UI primary and Semantic UI React legacy) with practical examples and clear upgrade pathways. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/STYLE-GUIDE.md`:
- Around line 58-63: Update the fenced code block in STYLE-GUIDE.md that shows
the component hierarchy so it includes a language specifier; change the
triple-backtick fence surrounding the lines starting with "Pages (routes)" and
the tree to use ```text (or leave unmarked for plain text) so the block renders
with the intended formatting.
🧹 Nitpick comments (1)
docs/STYLE-GUIDE.md (1)
432-448: Consider improving type safety for dark mode access.The example uses
(theme as any)to accesscolorSchemes.dark, which bypasses TypeScript's type safety. This suggests the theme types may not properly expose thecolorSchemesproperty.💡 Potential improvement
Consider creating a typed helper or extending the Theme interface to avoid the
anycast:// In a types file import { Theme as MuiTheme } from "@oxygen-ui/react/models/theme"; interface ExtendedTheme extends MuiTheme { colorSchemes?: { dark: { palette: { background: { default: string }; text: { primary: string }; }; }; }; } // Usage const theme = useTheme() as ExtendedTheme; const darkBg = theme.colorSchemes?.dark.palette.background.default;If the library doesn't expose these types, document this as a known limitation in the style guide.
| ``` | ||
| Pages (routes) | ||
| └── Features (business logic containers) | ||
| └── Compositions (component combinations) | ||
| └── Base Components (atoms/molecules) | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add language specifier to fenced code block.
The fenced code block lacks a language specifier. Add text or leave it unmarked for plain text display.
📝 Proposed fix
-```
+```text
Pages (routes)
└── Features (business logic containers)
└── Compositions (component combinations)
└── Base Components (atoms/molecules)</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
58-58: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
In `@docs/STYLE-GUIDE.md` around lines 58 - 63, Update the fenced code block in
STYLE-GUIDE.md that shows the component hierarchy so it includes a language
specifier; change the triple-backtick fence surrounding the lines starting with
"Pages (routes)" and the tree to use ```text (or leave unmarked for plain text)
so the block renders with the intended formatting.
| | **Oxygen UI** | Material UI 5(MUI) | Active | New components | | ||
| | **Semantic UI React** | Custom SCSS | Legacy | Existing components | | ||
|
|
||
| **Oxygen UI** (`@oxygen-ui/react`) is our design system built on MUI. It provides consistent theming, accessibility, and alignment with WSO2's product design language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Oxygen UI** (`@oxygen-ui/react`) is our design system built on MUI. It provides consistent theming, accessibility, and alignment with WSO2's product design language. | |
| **Oxygen UI** (`@oxygen-ui/react`) is our design system built on MUI. It provides consistent theming, accessibility, and alignment with WSO2's product design guidelines. |
Purpose
$subject
Related Issues
Related PRs
Checklist
Security checks
Developer Checklist (Mandatory)
product-isissue to track any behavioral change or migration impact.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.