Skip to content

Sets the script to the default script instead of an empty string when reseting adaptive script #9740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HasiniSama wants to merge 3 commits into
base: master
Choose a base branch
from
+12 −2
Open

Sets the script to the default script instead of an empty string when reseting adaptive script #9740

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b0ebc6
Sets the script to the default script instead of an empty string when…
HasiniSama Mar 11, 2026
257cf61
Add changeset 🦋
HasiniSama Mar 11, 2026
772015b
* Set reset default script as source and internal editor value consis…
HasiniSama Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...plications.v1/components/settings/sign-on-methods/script-based-flow/script-based-flow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* Copyright (c) 2020-2024, WSO2 LLC. (https://www.wso2.com).
* Copyright (c) 2020-2026, WSO2 LLC. (https://www.wso2.com).
*
* WSO2 LLC. licenses this file to you under the Apache License,
* Version 2.0 (the "License"); you may not use this file except
Expand Down Expand Up @@ -565,7 +565,7 @@ export const ScriptBasedFlow: FunctionComponent<AdaptiveScriptsPropsInterface> =
};

const resetAdaptiveScriptTemplateToDefaultHandler = () => {
setSourceCode("");
setSourceCode(AdaptiveScriptUtils.generateScript(authenticationSteps + 1));
Copy link
Contributor

@NipuniBhagya NipuniBhagya Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we expecting to save the default script when disabling the conditional authentication?

Copy link
Contributor Author

@HasiniSama HasiniSama Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the previous default behavior for the Classic Editor. It was changed when introducing the Script Update REST API feature [1]. Since this feature is disabled by default, this change introduced a regression in the Classic Editor.

Additionally, since the previous behavior aligns with the Visual Editor, we propose reverting to the earlier implementation to avoid breaking the current flow.

[1] a9c5cf7#diff-6eb727e98b131f02e3e21db95b23fadb0fe174733537a3a163a1e5e0e7faa5c7R579

setIsScriptFromTemplate(false);
onAdaptiveScriptReset();
onConditionalAuthenticationToggle(false);
Expand Down
Loading