Skip to content

Fixing issues with model based round robin #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CrowleyRajapakse merged 1 commit into from
Feb 26, 2025
Merged

Fixing issues with model based round robin #1270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion apim-apk-agent/pkg/transformer/transformer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,13 @@ func getReqAndResInterceptors(reqPolicyCount, resPolicyCount int, reqPolicies []
PolicyName: modelBasedRoundRobin,
PolicyVersion: v1,
}
configs := reqPolicy.Parameters["weightedRoundRobinConfigs"]
var configs interface{}
if reqPolicy.PolicyName == constants.ModelRoundRobin {
configs = reqPolicy.Parameters["roundRobinConfigs"]
} else if reqPolicy.PolicyName == constants.ModelWeightedRoundRobin {
configs = reqPolicy.Parameters["weightedRoundRobinConfigs"]
}

logger.LoggerTransformer.Debugf("Configs: %v", configs)
// Convert interface{} to string, then to []byte
configStr, ok := configs.(string)
Expand Down Expand Up @@ -575,6 +581,9 @@ func getReqAndResInterceptors(reqPolicyCount, resPolicyCount int, reqPolicies []
}
for _, model := range config.Production {
endpointURL := endpointIdtoURL[model.EndpointID]
if model.Weight == 0 {
model.Weight = 1
}
modelEndpoints := ModelEndpoints{
Model: model.Model,
Weight: model.Weight,
Expand All @@ -583,6 +592,9 @@ func getReqAndResInterceptors(reqPolicyCount, resPolicyCount int, reqPolicies []
productionModels = append(productionModels, modelEndpoints)
}
for _, model := range config.Sandbox {
if model.Weight == 0 {
model.Weight = 1
}
endpointURL := endpointIdtoURL[model.EndpointID]
modelEndpoints := ModelEndpoints{
Model: model.Model,
Expand Down
Loading