Bump carbon registry version to introduce Solr 10.0.0#26956
Bump carbon registry version to introduce Solr 10.0.0#26956KD23243 wants to merge 2 commits intowso2:masterfrom
Conversation
WalkthroughProject metadata updated: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@LICENSE.txt`:
- Line 299: LICENSE.txt still lists multiple
org.wso2.carbon.registry.*_4.9.4.jar entries while pom.xml bumped
carbon.registry.version to 4.9.5; update every occurrence of the registry
artifact filenames in LICENSE.txt (the 15 entries for
org.wso2.carbon.registry.*_4.9.4.jar) to use _4.9.5 so the LICENSE reflects the
actual shipped jars resolved via ${carbon.registry.version}; verify and replace
each instance to avoid version mismatch between LICENSE.txt and the built
distribution.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9e492d9e-9ae1-42c0-8a9a-0a8cef21b8f2
📒 Files selected for processing (2)
LICENSE.txtpom.xml
🚧 Files skipped from review as they are similar to previous changes (1)
- pom.xml
KD23243
changed the title
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
LICENSE.txt (1)
299-330:⚠️ Potential issue | 🔴 CriticalUpdate Lucene dependency to match Solr 10.0.0 requirements.
Apache Solr 10.0.0 requires Lucene 10.3.2, but the LICENSE.txt lists
lucene-core-9.12.2.jarat line 330. This is a critical incompatibility. Updatelucene-core-9.12.2.jartolucene-core-10.3.2.jar(or verify thatsolr_10.0.0.wso2v1.jarbundles Lucene 10.3.2 internally and remove the separate lucene-core dependency from the license file).Also confirm that supporting dependencies (ZooKeeper 3.9.4, Jersey 3.1.5, Jetty 10.0.26, Calcite 1.37.0) are compatible with Solr 10.0.0.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@LICENSE.txt` around lines 299 - 330, The LICENSE.txt lists lucene-core-9.12.2.jar which is incompatible with solr_10.0.0.wso2v1.jar (Solr 10.0.0 requires Lucene 10.3.2); update the entry lucene-core-9.12.2.jar to lucene-core-10.3.2.jar or, if solr_10.0.0.wso2v1.jar already bundles Lucene 10.3.2, remove the separate lucene-core entry and note that it’s included in the Solr bundle; additionally verify compatibility of related entries (zookeeper-3.9.4.jar, jersey-3.1.5.jar, jetty-10.0.26.jar, calcite-core-1.37.0.jar) with Solr 10.0.0 and update or annotate the LICENSE.txt accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@LICENSE.txt`:
- Around line 299-330: The LICENSE.txt lists lucene-core-9.12.2.jar which is
incompatible with solr_10.0.0.wso2v1.jar (Solr 10.0.0 requires Lucene 10.3.2);
update the entry lucene-core-9.12.2.jar to lucene-core-10.3.2.jar or, if
solr_10.0.0.wso2v1.jar already bundles Lucene 10.3.2, remove the separate
lucene-core entry and note that it’s included in the Solr bundle; additionally
verify compatibility of related entries (zookeeper-3.9.4.jar, jersey-3.1.5.jar,
jetty-10.0.26.jar, calcite-core-1.37.0.jar) with Solr 10.0.0 and update or
annotate the LICENSE.txt accordingly.
1 participant
Summary by CodeRabbit