Refactor saas app creation test case

[sadilchamishka]

Summary by CodeRabbit

• Tests
  • Updated test resource to set the SaaS flag to false for application advanced configuration.
  • Removed a specific assertion that validated toggling the SaaS flag during patch updates; other advanced-configuration checks remain unchanged.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5ffa1a4a-1766-4540-860f-c710b6573d05

📥 Commits

Reviewing files that changed from the base of the PR and between 920d50f and 95212dd.

📒 Files selected for processing (2)

• modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/rest/api/server/application/management/v1/ApplicationPatchTest.java
• modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/application/management/v1/patch-application-advanced-configuration.json

💤 Files with no reviewable changes (1)

• modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/rest/api/server/application/management/v1/ApplicationPatchTest.java

✅ Files skipped from review due to trivial changes (1)

• modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/application/management/v1/patch-application-advanced-configuration.json

---

Walkthrough

Updated test artifacts: the test JSON flips advancedConfigurations.saas from true to false, and the corresponding Java integration test removed an assertion checking that saas was set to true after a PATCH. No other functional changes.

Changes

Cohort / File(s)	Summary
Test Configuration JSON modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/application/management/v1/patch-application-advanced-configuration.json	Changed advancedConfigurations.saas value from true to false.
Integration Test Java modules/integration/tests-integration/tests-backend/src/test/java/org/wso2/identity/integration/test/rest/api/server/application/management/v1/ApplicationPatchTest.java	Removed the assertion that verified advancedConfigurations entry saas changed to true after PATCH; other assertions unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Refactor saas app creation test case #27321: Related change that removes SaaS flag assertions in Java tests; overlaps test expectations for the saas flag.

Suggested reviewers

• RushanNanayakkara
• jenkins-is-staging

Poem

🐰 A tiny flip in testland's light,
From true to false in JSON's sight,
A removed assertion — quiet and neat,
Tests hop onward on padded feet. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Refactor saas app creation test case' accurately describes the main changes: modifications to SaaS-related test configurations and test assertions in the application management integration tests.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch skip-creating-saas-apps-1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR updates an integration test fixture used by the Application Management REST API PATCH tests, changing the advancedConfigurations.saas value in the advanced-configuration patch payload.

Changes:

• Modify the patch-application-advanced-configuration.json test resource to set "saas": false instead of true.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/application/management/v1/patch-application-advanced-configuration.json`:
- Line 3: The fixture in patch-application-advanced-configuration.json sets
"saas": false which contradicts the expectation in
ApplicationPatchTest.testUpdateAdvancedConfiguration() that saas becomes true;
either change the JSON value to "saas": true to match the test intent, or update
the assertion in ApplicationPatchTest.testUpdateAdvancedConfiguration() to
expect false (and adjust any related assertions or test comments). Locate the
JSON payload (patch-application-advanced-configuration.json) and the test method
(ApplicationPatchTest.testUpdateAdvancedConfiguration) to make the matching
change so the fixture and assertion agree.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8eab5ef9-7cac-4376-ab85-c6ed82309608

📥 Commits

Reviewing files that changed from the base of the PR and between 1b34d20 and 920d50f.

📒 Files selected for processing (1)

• modules/integration/tests-integration/tests-backend/src/test/resources/org/wso2/identity/integration/test/rest/api/server/application/management/v1/patch-application-advanced-configuration.json

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud