Skip to content

Fix handlers adding issue in the API form #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HashanTG wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix handlers adding issue in the API form #671

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ef990e
chanege the file name index.js inside the APIform folder in Forms
HashanTG Oct 16, 2025
009537d
i change index file in mi/mivisualizer/froms/apiform so i fix when ad…
HashanTG Oct 21, 2025
e9ce1a8
Merge branch 'main' into fix/1235-multiple-handlers
ChinthakaJ98 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions workspaces/mi/mi-visualizer/src/views/Forms/APIform/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,14 +367,13 @@ export function APIWizard({ apiData, path }: APIWizardProps) {
};

const addNewHandler = () => {
if (handlers.length === 0) {
// Always allow adding a new handler row (even if previous is empty)
// We will sanitize empty handlers on save.
if (!handlers || handlers.length === 0) {
setValue("handlers", [{ name: "", properties: [] }], { shouldValidate: true, shouldDirty: true });
return;
} else {
setValue("handlers", [...handlers, { name: "", properties: [] }], { shouldValidate: true, shouldDirty: true });
}

const lastHandler = handlers[handlers.length - 1];
if (lastHandler.name === "" || lastHandler.properties.length === 0) return;
setValue("handlers", [...handlers, { name: "", properties: [] }], { shouldValidate: true, shouldDirty: true });
}

const handleCreateAPI = async (values: any) => {
Expand Down Expand Up @@ -440,14 +439,21 @@ export function APIWizard({ apiData, path }: APIWizardProps) {
}
const xml = getXML(ARTIFACT_TEMPLATES.EDIT_API, formValues);
// Combine regular handlers with CORS handler if enabled and version supports it
const allHandlers = [...handlers];
// Prepare handlers: allow editing UI to have empty rows but filter them out for XML
const allHandlers = [...(handlers || [])];
const cleanedHandlers = allHandlers
.filter((h: any) => (h?.name ?? '').toString().trim() !== "")
.map((h: any) => ({
name: h.name,
properties: (h.properties || []).filter((p: any) => ((p?.name ?? '').toString().trim() !== "" && (p?.value ?? '').toString().trim() !== ""))
}));
if (shouldShowCORSSettings) {
const corsHandler = createCORSHandler(values.corsSettings);
if (corsHandler) {
allHandlers.push(corsHandler);
cleanedHandlers.push(corsHandler);
}
}
const handlersXML = getXML(ARTIFACT_TEMPLATES.EDIT_HANDLERS, { show: allHandlers.length > 0, handlers: allHandlers });
const handlersXML = getXML(ARTIFACT_TEMPLATES.EDIT_HANDLERS, { show: cleanedHandlers.length > 0, handlers: cleanedHandlers });
const editAPIParams = {
documentUri: path,
apiName: values.apiName,
Expand Down