Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the file output mechanism from a repository-based chunked approach to a filesystem-based temporary file approach. It also adds a new CSV output example script and enhances an existing XLS output script with abort checking.
- Refactored
FileOutput.javato use temporary files instead ofRepoChunksfor better performance with large file outputs - Added a new CSV report generation example script that can generate up to 5 million user records
- Enhanced the XLS output script with abort checking and increased default user count to 100,000
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| core/src/main/java/dev/vml/es/acm/core/code/FileOutput.java | Refactored to use filesystem temporary files instead of repository chunks for file output streaming |
| ui.content.example/.../ACME-203_output-xls.groovy | Increased default user count from 1,000 to 100,000 and added abort checking in the generation loop |
| ui.content.example/.../ACME-203_output-csv.groovy | New CSV report generation script demonstrating file output with configurable user generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...src/main/content/jcr_root/conf/acm/settings/script/manual/example/ACME-203_output-csv.groovy
Show resolved
Hide resolved
...src/main/content/jcr_root/conf/acm/settings/script/manual/example/ACME-203_output-csv.groovy
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.