[pull] master from php:master #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…19712) These act on LONGs, so dtor'ing them is pointless.
* uri: Do not copy the normalized URI when cloning RFC 3986 URIs The with-ers are not yet implemented for RFC 3986, the argument in the comment however makes sense and the implementation did not match the comment. * uri: Fix typo in comment in uri_parser_rfc3986.c Co-authored-by: Máté Kocsis <[email protected]> --------- Co-authored-by: Máté Kocsis <[email protected]>
This commit implements GH-8967. SQLite supports multiple transaction modes. These include: - DEFERRED (default) only acquires a lock when you start a read/write - IMMEDIATE acquires a reserved lock - EXCLUSIVE acquires an exclusive lock (stricter than immediate) In WAL mode IMMEDIATE and EXCLUSIVE are identical. One reason for wanting to specify a transaction mode is that SQLite doesn't respect busy_timeout when a DEFERRED transaction tries to upgrade a read lock to a write lock. Normally if you try to acquire a lock and have busy_timeout configured, SQLite will wait for that period until giving up and erroring out (SQLITE_BUSY). With DEFERRED, if you have a transaction that first reads and there's a concurrent writer while it's trying to upgrade to a write lock, you will immediately get SQLITE_BUSY regardless of your busy_timeout. Prior to this commit, the only available workarounds were: - Using $pdo->exec("BEGIN IMMEDIATE TRANSACTION") instead of $pdo->beginTransaction() - Doing a dummy write at the start of each transaction so you don't get stuck with a read lock Both of those aren't very usable, especially in a framework context where the user doesn't have complete control over how transactions are started. To address that, this commit adds four class constants to Pdo\Sqlite: - ATTR_TRANSACTION_MODE -- a new attribute - TRANSACTION_MODE_DEFERRED = 0 - TRANSACTION_MODE_IMMEDIATE = 1 - TRANSACTION_MODE_EXCLUSIVE = 2 These can be used as: $pdo->setAttribute( $pdo::ATTR_TRANSACTION_MODE, $pdo::TRANSACTION_MODE_IMMEDIATE );
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )