[pull] master from php:master #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rename code can error out prior to the reassignment of the filename, which is why the test causes a crash. The rename code can also error out at a later point, which means it will have already assigned the new filename. We detect in which case we are in and act accordingly. Closes GH-19761.
* PHP-8.3: Fix GH-19752: Phar decompression with invalid extension can cause UAF
* PHP-8.4: Fix GH-19752: Phar decompression with invalid extension can cause UAF
…hatwg (#19748) * uri: Fix handling of the `errors == NULL && !silent` for uri_parser_whatwg Previously, when `errors` was `NULL`, the `errors` pointer was used to set the `$errors` property when throwing the exception, leading to a crash. Use a local zval to pass the errors to the Exception and copy it into the `errors` input when it is non-`NULL`. * uri: Only pass the `errors` zval when interested in it in `php_uri_instantiate_uri()` This is no longer necessary since the previous commit and also is a layering violation, since `php_uri_instantiate_uri()` should not care how `parse_uri()` works internally. * uri: Use `ZVAL_EMPTY_ARRAY()` when no parsing errors are available * uri: Avoid redundant refcounting in error handling of uri_parser_whatwg * NEWS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )