[pull] master from php:master #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* uri: Check early whether we would be overwriting an existing URI in `uri_unserialize()` * uri: Access the CE consistently in `uri_unserialize()`
The functions derived non-const pointers from a const-pointer, which is not correct. Since #19854 no `const` pointers are passed into these functions, so we can just make the parameter non-const.
* uri: Fix handling of large port numbers in URI struct * uri: Explain the choice of type for `php_uri.port` * NEWS
…19827) The __wakeup() method is obsolete as a __unserialize() magic method is implemented. Therefore, any class extending from those classes that overload deserialization should call the __unserialize() method instead of __wakeup() to properly handle the deserialization. This deprecation follows the wording of the deprecation of the SplFixedArray::__wakeup() magic method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )