[pull] master from php:master #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API does not require the "global" security workaround. We also pass some additional options for hardening.
* PHP-8.3: Fix memory leak and invalid continuation after tar header writing fails
* PHP-8.4: Fix memory leak and invalid continuation after tar header writing fails
* PHP-8.5: Fix memory leak and invalid continuation after tar header writing fails
* PHP-8.4: Fix build
* PHP-8.5: Fix build
* PHP-8.5: Fix typos and grammar in UPGRADING
Or on Windows it is going to use either FormatMessageW or strerror_s for compatibility with previous error messages. It also needs to accomodate for GNU and BSD versions of strerror_r returning different type. Closes GH-19251
Change the reproducer code in `bug35916.phpt` from `stream_bucket_append` to `stream_bucket_prepend` and you have the same bug. Furthermore, even in the append case the check is incorrect because the bucket can already be in the brigade at a position other than the tail. To solve this properly, unlink the brigade first and also use that as a condition to manage the refcount. Closes GH-18973.
* PHP-8.3: Fix GH-17345: Bug #35916 was not completely fixed
* PHP-8.4: Fix GH-17345: Bug #35916 was not completely fixed
* PHP-8.5: Fix GH-17345: Bug #35916 was not completely fixed
* PHP-8.4: Fix test
* PHP-8.5: Fix test
* PHP-8.4: Fix GH-20022: docker-php-ext-install DOM failed
* PHP-8.5: Fix GH-20022: docker-php-ext-install DOM failed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )