[pull] master from php:master #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=80&v=4){kind=small}
If object initialization fails the zval will be NULL, that's an implementation detail. However, it's very confusing for a reader to destroy a seemingly uninitialized zval.
The phar is CoW'd, so it is non-persistent.
The PHAR_ZIP_FAIL and PHAR_ZIP_FAIL_FREE macros are almost the same. The reason the latter exists is because of a single error path where the error message is on the heap and needs to be freed. Instead, use a stack allocated variable for the error message so we can get rid of the duplicate macro code. This stack variable is big enough as the messages written by phar_verify_signature() are short. Closes GH-20144.
* PHP-8.3: phar: Reduce code duplication wrt error handling in phar_parse_zipfile()
* PHP-8.4: phar: Reduce code duplication wrt error handling in phar_parse_zipfile()
* PHP-8.5: phar: Reduce code duplication wrt error handling in phar_parse_zipfile()
…lter is provided Closes GH-20071
* PHP-8.3: Fix GH-20070: Return type violation in imagefilter when an invalid filter is provided
* PHP-8.4: Fix GH-20070: Return type violation in imagefilter when an invalid filter is provided
* PHP-8.5: Fix GH-20070: Return type violation in imagefilter when an invalid filter is provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )