[pull] master from php:master #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=80&v=4){kind=small}
This simplifies some of the logic and makes the assumptions clear
…ction() This is incredibly confusing.
While at it, also add VECTOR. Closes GH-20143.
* PHP-8.3: Fix GH-20122: getColumnMeta() for JSON-column in MySQL
* PHP-8.4: Fix GH-20122: getColumnMeta() for JSON-column in MySQL
* PHP-8.5: Fix GH-20122: getColumnMeta() for JSON-column in MySQL
Bailouts are bad because they stop the GC etc. They also hide leaks. This makes the behaviour equivalent to exit(), as it's meant to stop the request (which is why bailout was used). We also have to fix some leaks that pop up then.
* PHP-8.4: Fix test on 8.4+
* PHP-8.5: Fix test on 8.4+
* PHP-8.4: [ci skip] Fail test temporarily
* PHP-8.5: [ci skip] Fail test temporarily
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )