[pull] master from php:master #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=80&v=4){kind=small}
There have been misterious macOS failures with the following error for a long time, which would usually happen 1-2x per nightly run: > The hosted runner lost communication with the server. Anything in your > workflow that terminates the runner process, starves it for CPU/Memory, or > blocks its network access can cause this error. After way too much debugging, it looks like this is caused by the two fpm tests skipped in this commit. When there's a failure, the responsible test will run for at least 120 seconds until the job is eventually killed by GitHub Actions. It's not clear yet why the tests stall. Debugging this is a PITA because the GitHub Actions log gets partially lost for killed jobs. It took an external log server to actually figure out where the job fails. Let's disable the tests first to be sure this actually solves the issue.
* PHP-8.1: [skip ci] Skip suspicious fpm tests on GH actions & macOS
* PHP-8.2: [skip ci] Skip suspicious fpm tests on GH actions & macOS
* PHP-8.3: [skip ci] Skip suspicious fpm tests on GH actions & macOS
* PHP-8.4: [skip ci] Skip suspicious fpm tests on GH actions & macOS
* PHP-8.5: [skip ci] Skip suspicious fpm tests on GH actions & macOS
Should've been skip, not flaky...
* PHP-8.1: [skip ci] Fix typo
* PHP-8.2: [skip ci] Fix typo
* PHP-8.3: [skip ci] Fix typo
* PHP-8.4: [skip ci] Fix typo
* PHP-8.5: [skip ci] Fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )