[pull] master from php:master #1137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=80&v=4){kind=small}
`error` is NULL at this point, otherwise we couldn't have gotten and *shouldn't* have gotten here in the first place.
… formatting string (#20229)
This is an alias for zval_ptr_dtor_nogc(). I've seen people make mistakes against this and use zval_dtor() instead of zval_ptr_dtor(). The crucial detail here is that the former won't root possible GC cycles while the latter will. We can avoid the confusion by just retiring this compatibility macro. Closes GH-20235.
This also avoids some unnecessary zend_string overhead.
… already ends in a newline
* PHP-8.3: phar: Fix memory leak when openssl polyfill returns garbage
* PHP-8.4: phar: Fix memory leak when openssl polyfill returns garbage
* PHP-8.5: phar: Fix memory leak when openssl polyfill returns garbage
* PHP-8.5: Fix merge issue
* PHP-8.1: Create separate workflow for nightly slack notification
* PHP-8.2: Create separate workflow for nightly slack notification
* PHP-8.3: Create separate workflow for nightly slack notification
* PHP-8.4: Create separate workflow for nightly slack notification
* PHP-8.5: Create separate workflow for nightly slack notification
* Fix Windows test for openssl-3.5 upgrade * Update ext/openssl/tests/check_default_conf_path.phpt Co-authored-by: Christoph M. Becker <[email protected]> --------- Co-authored-by: Christoph M. Becker <[email protected]>
* PHP-8.2: Fix Windows test for openssl-3.5 upgrade (#19384)
* PHP-8.3: Fix Windows test for openssl-3.5 upgrade (#19384)
* PHP-8.4: Fix Windows test for openssl-3.5 upgrade (#19384)
* PHP-8.5: Fix Windows test for openssl-3.5 upgrade (#19384)
* PHP-8.2: [skip ci] Skip openssl tests currently failing on 8.2
* PHP-8.3: [skip ci] Skip openssl tests currently failing on 8.2
* PHP-8.4: [skip ci] Skip openssl tests currently failing on 8.2
* PHP-8.5: [skip ci] Skip openssl tests currently failing on 8.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )