[pull] master from php:master #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must use `mpz_fits_si_p()` instead of `mpz_fits_slong_p()` since the latter is not suitable for LLP64 data models. libgmp, however, does not define `mpz_fits_si_p()` (which is an mpir addition), so we use `mpz_fits_slong_p()` there which should be fine. Closes GH-16891.
* PHP-8.3: Fix GH-16890: array_sum() with GMP can loose precision (LLP64)
* PHP-8.4: Fix GH-16890: array_sum() with GMP can loose precision (LLP64)
The `vmactions/freebsd-vm` GitHub action rsyncs the work dir to to the VM. This adds a lot of log output due to `rsync -v` usage. Once the tests are compelte, the action copies the files _back_ by running `rsync` in reverse. However, we do not need these files back because we do not run any other steps that need access to the post-test files. Setting `copyback: false` disables this, and cuts the log size by about 5,000 lines. Closes Closes GH-16916.
* PHP-8.1: CI: FreeBSD on VM - set `copyback: false`
* PHP-8.2: CI: FreeBSD on VM - set `copyback: false`
* PHP-8.3: CI: FreeBSD on VM - set `copyback: false`
* PHP-8.4: CI: FreeBSD on VM - set `copyback: false`
copy_variation1.phpt also creates and deletes a file copy.tmp in the same folder, so conflicts may occur[1]. We apply a quick fix. [1] <https://github.com/php/php-src/actions/runs/11902293714/job/33167012826> Closes GH-16854.
* PHP-8.2: Fix potential conflict of copy_variation5-win32.phpt
* PHP-8.3: Fix potential conflict of copy_variation5-win32.phpt
* PHP-8.4: Fix potential conflict of copy_variation5-win32.phpt
Apparently, these have been overlooked when the macro definitions have been moved from dns.c to php_dns.h[1]. [1] <6f2f228>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )