[pull] master from php:master #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the stack reserve of php.exe and php-cgi.exe is very large on Windows (64MB)[1]. While this might not be bad for production purposes, it causes stack_limit_014.phpt to be unbearably slow; the test may easily run for a minute, and due to a recent `stream_select()` improvement[2], that can cause a timeout, what triggers the test to be run again. So this single test case may run for two minutes, and still might fail (happened a couple of times). Instead of skipping the test in CI, we reduce the stack reserve to 8MB, what improves the performance of this test case (and maybe others), and should still be good enough for CI. [1] <54906c7> [2] <b614b4a>
These test cases differ only in some details, so it doesn't make much sense to have separate test cases, given that POSIX/Windows test pairs are not unlikely to diverge over time (as can be seen here, where the POSIX tests are skipped for repeat runs, but the Windows tests are not).
The `--EXTENSIONS--` section already ensures that ext/readline is available, so there's no need to additionally check for unconditionally available readline functions. Closes GH-17170.
* PHP-8.4: Correctly round rounding mode with zero edge case (#17065)
* PHP-8.3: Fix GH-16255: Unexpected nan value in ext/gd/libgd/gd_filter.c
…_FUNC_ARG) ZEND_FETCH_DIM_FUNC_ARG should also be repeated on undefined access, consistent to how ZEND_FETCH_DIM_R is handled. The opcode was just missing from the assertion list. Closes GH-17148. Co-authored-by: Dmitry Stogov <[email protected]>
The original patch[1] cared only about pipe handles in the rset, but would be problematic if there are other handles (e.g. files in the rset, or pipes/files in the other sets), because `php_select()` would return immediately, reporting all non read-pipe handles as ready, but possibly never reporting read-pipe handles. We fix this by applying different logic for the case where only pipe handles are supplied in the rset, but no handles in the wset or eset. In this case `php_select()` only returns when actually one of the handles is ready, or when the timeout expires. To avoid busy looping in this case, we sleep for a short amount of time. This matches POSIX behavior. In all other cases, `php_select()` behaves as before (i.e. prior to the original fix), that is it returns immediately, reporting all handles as ready. We also add a test case that demonstrates multiplexing the output of a couple of child processes. See also the discussion on <#16917>. [1] <b614b4a> Closes GH-17174.
…t_long. to be explicit when the expected type is not met. Check SO_LINGER values for possible overflow. close GH-17135
Not sure why this happens only on master.
The test expectations are overly specific, and may not be met. For now, we're dropping the test case.
Co-authored-by: Saki Takamachi <[email protected]>
* Refactor usage of strlcpy As we allocate the buffer, we know the string will fit inside the buffer. * Throw ValueErrors when strings contain null bytes The underlying C calls work with C strings, which are NULL terminated. * exec_pcntl() always return false Thus, update stubs to formally have a return type of `false`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )