Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Mar 8, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

iluuu1994 added 11 commits March 8, 2025 12:27
* PHP-8.4:
  Fix incorrect handling of hooked props without get hook in get_object_vars()
Go through the normal assignment path, which includes an IS_UNDEF check.

Fixes GH-17998
Closes GH-17999
* PHP-8.4:
  Fix skipped lazy init on primed SIMPLE_WRITE
Writing to an uninitialized lazy proxy will initialize the underlying
object and then call zend_std_write_property() on it. If this happens
inside a hook, zend_std_write_property() should not call the hook again
but directly write to the property slot. This didn't previously work
because zend_should_call_hook() would compare the parent frame
containing the proxy to the underlying object. This is now handled
explicitly.

Fixes GH-18000
Closes GH-18001
* PHP-8.4:
  Fix lazy proxy calling set hook twice
I don't know enough about this library to fix those :(

Cherry-picked from:
be4db6b
ba1d9d0
* PHP-8.1:
  Suppress snmp lib memory leak, skip ASAN tests
* PHP-8.2:
  Suppress snmp lib memory leak, skip ASAN tests
* PHP-8.3:
  Suppress snmp lib memory leak, skip ASAN tests
* PHP-8.4:
  Suppress snmp lib memory leak, skip ASAN tests
@pull pull bot added the ⤵️ pull label Mar 8, 2025
@pull pull bot merged commit 30ce9ac into wudi:master Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant