[pull] master from php:master #911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function always returned SUCCESS unconditionally; removing the return type revealed some impossible code for handling FAILURE that could also be removed.
…et up (#19146) * opcache: Reset `accel_startup_ok` after shutting down This is necessary for phpdbg, which runs multiple startup/shutdown cycles in the same process. * opcache: Disallow changing `opcache.memory_consumption` when SHM is set up Normally changing the INI value is not possible after SHM is set up, since it is `PHP_INI_SYSTEM`. FPM is a notable exception: SHM is set up in the master process, but when spawning the individual pools, the `php_admin_value` config option can be used to change `PHP_INI_SYSTEM` INIs on a per-pool basis. This does not work for this option, since it will only be read on early start, leading to misleading PHPInfo output, since the INI value appears to be successfully set and since some of the calculated values are derived from the INI value rather than the actual value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )