[pull] master from php:master #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* uri/standard: Move the `parse_url()` URI parser into ext/uri/ Making ext/standard depend on ext/uri/ is a bit iffy (given that it is called *standard*) and having the parser implementation in ext/uri/ makes it easier to find and keep in sync. * uri: Mark local pointers as `const` in uri_parser_php_parse_url.c * uri: Remove useless explicit cast from void in uri_parser_php_parse_url.c * uri: Properly prefix symbols in uri_parser_php_parse_url.[ch] * uri: Remove useless `throw_invalid_uri_exception()` helper in uri_parser_php_parse_url.c
Don't use persistent string/attribute for the global SID constant, which is created at runtime and destroyed at the end of the request. Requires CFLAGS="-DZEND_RC_DEBUG=1" to reproduce. Closes GH-19595
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )