Skip to content

Fix #1364: Use database onboarding process configuration instead of properties#1435

Merged
michal-rozehnal-w merged 16 commits intodevelopfrom
issues/1364-Use-database-onboarding-process-configuration-instead-of-properties
Jan 8, 2026
Merged

Fix #1364: Use database onboarding process configuration instead of properties#1435
michal-rozehnal-w merged 16 commits intodevelopfrom
issues/1364-Use-database-onboarding-process-configuration-instead-of-properties

Conversation

@michal-rozehnal-w
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice start. I am nervous about changes to the mobile API. Moreover, I do not want to push it much to version 2.0.0

@banterCZ banterCZ requested a review from kober32 December 11, 2025 14:23
@kober32
Copy link
Member

kober32 commented Jan 6, 2026

My take is that the API (for FE) could be much simpler while keeping the feature set:

"documents": {
    "totalRequiredDocumentsCount": 3,
    "groups": [
      {
        "requiredDocumentsCount": 1,
        "items": [
          {
            "type": "ID_CARD",
            "sideCount": 2
          },
          {
            "type": "PASSPORT",
            "sideCount": 1
          }
        ]
      },
      {
        "requiredDocumentsCount": 1,
        "items": [
          {
            "type": "BIRTH_CERTIFICATE",
            "sideCount": 1
          },
          {
            "type": "STAY_PERMIT",
            "sideCount": 1
          }
        ]
      },
      {
        "requiredDocumentsCount": 0,
        "items": [
          {
            "type": "DRIVING_LICENCE",
            "sideCount": 1
          }
        ]
      }
    ]
  }

@@ -45,21 +45,30 @@ public record ConfigurationResponse(

@Builder
public record Documents(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@banterCZ @kober32 please check these changes in the endpoint. It is according to the structure mentioned in #1435 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine, let's wait for @kober32 review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's wait for @kober32 review.
We are going to merge it into 2.0.0, right?

@@ -45,21 +45,30 @@ public record ConfigurationResponse(

@Builder
public record Documents(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine, let's wait for @kober32 review.

@michal-rozehnal-w
Copy link
Contributor Author

Looks good, let's wait for @kober32 review. We are going to merge it into 2.0.0, right?

Thank you for the review. Yes, it should go to 2.0.0 release

Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API OK with me, but please, no more changes to the API that we already gave customers 🥲

@michal-rozehnal-w michal-rozehnal-w merged commit 92cf101 into develop Jan 8, 2026
6 checks passed
@michal-rozehnal-w michal-rozehnal-w deleted the issues/1364-Use-database-onboarding-process-configuration-instead-of-properties branch January 8, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use database onboarding process configuration instead of properties

4 participants