Fix #1364: Use database onboarding process configuration instead of properties#1435
Conversation
…ss-configuration-instead-of-properties
...java/com/wultra/app/onboardingserver/impl/service/OnboardingProcessConfigurationService.java
Outdated
Show resolved
Hide resolved
...wultra/app/onboardingserver/common/database/OnboardingProcessConfigurationRepositoryTest.sql
Outdated
Show resolved
Hide resolved
...ava/com/wultra/app/enrollmentserver/api/model/onboarding/response/ConfigurationResponse.java
Outdated
Show resolved
Hide resolved
banterCZ
left a comment
There was a problem hiding this comment.
Thanks! Nice start. I am nervous about changes to the mobile API. Moreover, I do not want to push it much to version 2.0.0
docs/onboarding/PowerAuth-Enrollment-Onboarding-Server-2.0.0.md
Outdated
Show resolved
Hide resolved
...ava/com/wultra/app/enrollmentserver/api/model/onboarding/response/ConfigurationResponse.java
Outdated
Show resolved
Hide resolved
.../wultra/app/onboardingserver/common/database/entity/OnboardingProcessConfigurationValue.java
Outdated
Show resolved
Hide resolved
...java/com/wultra/app/onboardingserver/impl/service/OnboardingProcessConfigurationService.java
Outdated
Show resolved
Hide resolved
…ss-configuration-instead-of-properties
|
My take is that the API (for FE) could be much simpler while keeping the feature set: "documents": {
"totalRequiredDocumentsCount": 3,
"groups": [
{
"requiredDocumentsCount": 1,
"items": [
{
"type": "ID_CARD",
"sideCount": 2
},
{
"type": "PASSPORT",
"sideCount": 1
}
]
},
{
"requiredDocumentsCount": 1,
"items": [
{
"type": "BIRTH_CERTIFICATE",
"sideCount": 1
},
{
"type": "STAY_PERMIT",
"sideCount": 1
}
]
},
{
"requiredDocumentsCount": 0,
"items": [
{
"type": "DRIVING_LICENCE",
"sideCount": 1
}
]
}
]
} |
| @@ -45,21 +45,30 @@ public record ConfigurationResponse( | |||
|
|
|||
| @Builder | |||
| public record Documents( | |||
There was a problem hiding this comment.
@banterCZ @kober32 please check these changes in the endpoint. It is according to the structure mentioned in #1435 (comment)
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...va/com/wultra/app/onboardingserver/impl/service/OnboardingProcessConfigurationValueTest.java
Outdated
Show resolved
Hide resolved
...java/com/wultra/app/onboardingserver/impl/service/OnboardingProcessConfigurationService.java
Show resolved
Hide resolved
...rc/test/resources/com/wultra/app/onboardingserver/impl/service/OnboardingServiceImplTest.sql
Outdated
Show resolved
Hide resolved
.../wultra/app/onboardingserver/common/database/entity/OnboardingProcessConfigurationValue.java
Show resolved
Hide resolved
.../wultra/app/onboardingserver/common/database/entity/OnboardingProcessConfigurationValue.java
Show resolved
Hide resolved
.../wultra/app/onboardingserver/common/database/entity/OnboardingProcessConfigurationValue.java
Show resolved
Hide resolved
.../wultra/app/onboardingserver/common/database/entity/OnboardingProcessConfigurationValue.java
Show resolved
Hide resolved
docs/onboarding/PowerAuth-Enrollment-Onboarding-Server-2.0.0.md
Outdated
Show resolved
Hide resolved
| @@ -45,21 +45,30 @@ public record ConfigurationResponse( | |||
|
|
|||
| @Builder | |||
| public record Documents( | |||
.../wultra/app/onboardingserver/common/database/entity/OnboardingProcessConfigurationValue.java
Show resolved
Hide resolved
...wultra/app/onboardingserver/common/database/OnboardingProcessConfigurationRepositoryTest.sql
Show resolved
Hide resolved
.../com/wultra/app/onboardingserver/statemachine/guard/document/RequiredDocumentTypesCheck.java
Outdated
Show resolved
Hide resolved
.../wultra/app/onboardingserver/statemachine/guard/document/RequiredDocumentTypesCheckTest.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/com/wultra/app/onboardingserver/controller/api/ConfigurationController.java
Show resolved
Hide resolved
.../com/wultra/app/onboardingserver/statemachine/guard/document/RequiredDocumentTypesCheck.java
Outdated
Show resolved
Hide resolved
.../com/wultra/app/onboardingserver/statemachine/guard/document/RequiredDocumentTypesCheck.java
Show resolved
Hide resolved
Thank you for the review. Yes, it should go to |
kober32
left a comment
There was a problem hiding this comment.
API OK with me, but please, no more changes to the API that we already gave customers 🥲
No description provided.